Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request ports the valid-typeof rule from ESLint. The implementation is solid and well-tested, covering various edge cases and options like requireStringLiterals. The documentation is also clear and helpful.
I've left a couple of suggestions for improvement: one for a small refactoring in the Go rule implementation to follow language idioms, and another to clean up a redundant entry in the test configuration. Overall, great work on porting this rule.
a5376c5 to
d2a6d0e
Compare
e7deb90 to
68eb0c5
Compare
26b4494 to
c9ad0bf
Compare
c9ad0bf to
fa56c89
Compare
Summary
Port the
valid-typeofrule from ESLint to rslint.Enforce comparing typeof expressions against valid strings
Related Links
Tracking issue: [Tracking]: eslint core rules #223
ESLint rule: https://eslint.org/docs/latest/rules/valid-typeof
Checklist